Skip to content

Conversation

@lcnr
Copy link
Contributor

@lcnr lcnr commented Oct 27, 2025

Tracking this implicitly is kinda messy and easy to get wrong.

r? @BoxyUwU

@rustbot
Copy link
Collaborator

rustbot commented Oct 27, 2025

Some changes occurred in exhaustiveness checking

cc @Nadrieril

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 27, 2025
Comment on lines -553 to -555
for hidden_ty in fcx_typeck_results.hidden_types.values() {
assert!(!hidden_ty.has_infer());
}
Copy link
Contributor Author

@lcnr lcnr Oct 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ideally this is just an assert in EarlyBinder::bind. Adding that is more annoying than I expected as we need to do some lifetime dependent shit in some of the query system stuff which relies on transmutes. nm, actually just gonna do that in this PR as well

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also ass because we create ty::EarlyBinder<'tcx, impl IntoIterator<Item = ty::Binder<'tcx, ty::TraitRef<'tcx>>>> sometimes. An early binder of an iterator :x

@bors
Copy link
Collaborator

bors commented Oct 29, 2025

☔ The latest upstream changes (presumably #148220) made this pull request unmergeable. Please resolve the merge conflicts.

@lcnr lcnr force-pushed the opaques-early-binder branch from cd5dc48 to 3a6ab3f Compare October 29, 2025 09:45
@rustbot
Copy link
Collaborator

rustbot commented Oct 29, 2025

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants